[ 
https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465688#comment-16465688
 ] 

ASF GitHub Bot commented on FLINK-9276:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5954#discussion_r186376182
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
 ---
    @@ -86,9 +86,10 @@
         * Releases a TaskExecutor with the given {@link ResourceID} from the 
{@link SlotPool}.
         *
         * @param resourceId identifying the TaskExecutor which shall be 
released from the SlotPool
    +    * @param cause for the release the TaskManager
         * @return Future acknowledge which is completed after the TaskExecutor 
has been released
         */
    -   CompletableFuture<Acknowledge> releaseTaskManager(final ResourceID 
resourceId);
    +   CompletableFuture<Acknowledge> releaseTaskManager(final ResourceID 
resourceId, final Exception cause);
    --- End diff --
    
    Throwable, see above.


> Improve error message when TaskManager fails
> --------------------------------------------
>
>                 Key: FLINK-9276
>                 URL: https://issues.apache.org/jira/browse/FLINK-9276
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Stephan Ewen
>            Assignee: vinoyang
>            Priority: Critical
>
> When a TaskManager fails, we frequently get a message
> {code}
> org.apache.flink.util.FlinkException: Releasing TaskManager 
> container_1524853016208_0001_01_000102
> {code}
> This message is misleading in that it sounds like an intended operation, when 
> it really is a failure of a container that the {{ResourceManager}} reports to 
> the {{JobManager}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to