[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467193#comment-16467193
]
ASF GitHub Bot commented on FLINK-8655:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r186673807
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraPojoSink.java
---
@@ -50,18 +51,31 @@
* @param clazz Class instance
*/
public CassandraPojoSink(Class<IN> clazz, ClusterBuilder builder) {
- this(clazz, builder, null);
+ this(clazz, builder, null, null);
}
public CassandraPojoSink(Class<IN> clazz, ClusterBuilder builder,
@Nullable MapperOptions options) {
+ this(clazz, builder, options, null);
+ }
+
+ public CassandraPojoSink(Class<IN> clazz, ClusterBuilder builder,
String keyspace) {
+ this(clazz, builder, null, keyspace);
+ }
+
+ public CassandraPojoSink(Class<IN> clazz, ClusterBuilder builder,
@Nullable MapperOptions options, String keyspace) {
super(builder);
this.clazz = clazz;
this.options = options;
+ this.keyspace = keyspace;
}
@Override
public void open(Configuration configuration) {
+ if (keyspace != null && !keyspace.isEmpty()) {
+ configuration.setString("keyspace", keyspace);
--- End diff --
this has no effect as the configuration is never used anywhere, and thus
can be removed.
> Add a default keyspace to CassandraSink
> ---------------------------------------
>
> Key: FLINK-8655
> URL: https://issues.apache.org/jira/browse/FLINK-8655
> Project: Flink
> Issue Type: Improvement
> Components: Cassandra Connector
> Affects Versions: 1.4.0
> Reporter: Christopher Hughes
> Priority: Minor
> Labels: features
> Fix For: 1.6.0
>
>
> Currently, to use the CassandraPojoSink, it is necessary for a user to
> provide keyspace information on the desired POJOs using datastax annotations.
> This allows various POJOs to be written to multiple keyspaces while sinking
> messages, but prevent runtime flexibility.
> For many developers, non-production environments may all share a single
> Cassandra instance differentiated by keyspace names. I propose adding a
> `defaultKeyspace(String keyspace)` to the ClusterBuilder. POJOs lacking a
> definitive keyspace would attempt to be loaded to the provided default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
