[
https://issues.apache.org/jira/browse/FLINK-9153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473495#comment-16473495
]
ASF GitHub Bot commented on FLINK-9153:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5834
Generally I would refrain from pinging specific committers. This can be
counter-productive as it discourages other committers, or even contributors,
from taking a look.
Similarly, pinging a committer in every PR because you saw them reviewing
other PRs at the time (as has happened to me last week) isn't that helpful
either. It just pushes even more work/pressure on the few committers that
actually do reviews.
(Note that frequent pinging inherently puts more work on me as i actually
monitor all PR updates!)
At last, please keep in mind that not all PRs have the same priority,
especially when working towards the next release.
Documentation changes (#5773) _can_ be merged after a release (since the
docs aren't part of the release!),
code-cleanups (#5777, #5799) and minor fixes (#5798) are usually
non-critical and always pose the risk of introducing new bugs which is the last
thing we want shortly before a release.
> TaskManagerRunner should support rpc port range
> -----------------------------------------------
>
> Key: FLINK-9153
> URL: https://issues.apache.org/jira/browse/FLINK-9153
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Affects Versions: 1.4.0, 1.5.0
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Fix For: 1.5.0
>
>
> TaskManagerRunner current just support one specific port :
> {code:java}
> final int rpcPort =
> configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, 0);
> {code}
> It should support port range as the document described :
> https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html#taskmanager-rpc-port
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
