[
https://issues.apache.org/jira/browse/FLINK-9153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473526#comment-16473526
]
ASF GitHub Bot commented on FLINK-9153:
---------------------------------------
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
@zentol thanks for your clarification. Actually, when I start join Flink
community, most of the PRs were reviewed by you and till. Both of you gave me a
lot of suggestion and technical opinion. What's more, you are the most
frequently in the issue mailing list. So I always ping you and till, I don't
know this behavior brought you burden. Maybe there is a bad phenomenon: more
times been saw, more times been pinged.
Actually, from my (a contributor like others) view point, I don't know the
committer's review plan. And the PRs take more time would take more cost
(especially, like this PR in reviewing status). The contributors and committers
both would look back into it's context. I ping you sometimes because I think
you are reviewing other PRs, at that point, maybe this behavior would not
disturb your coding. And sometimes, I may not need you to review immediately.
You can give a explication or time point about reviewing or ping another
committer (who work together with you) to review. Generally, a effective
feedback.
Now, I know your standpoint and trouble. Sorry about my behavior. You and
others are good.
cc @StephanEwen
> TaskManagerRunner should support rpc port range
> -----------------------------------------------
>
> Key: FLINK-9153
> URL: https://issues.apache.org/jira/browse/FLINK-9153
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Affects Versions: 1.4.0, 1.5.0
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Fix For: 1.5.0
>
>
> TaskManagerRunner current just support one specific port :
> {code:java}
> final int rpcPort =
> configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, 0);
> {code}
> It should support port range as the document described :
> https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html#taskmanager-rpc-port
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
