[ 
https://issues.apache.org/jira/browse/FLINK-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476701#comment-16476701
 ] 

ASF GitHub Bot commented on FLINK-8944:
---------------------------------------

Github user kailashhd commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5992#discussion_r188481158
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
 ---
    @@ -97,8 +228,7 @@ public void testClientConfigOverride() {
     
                AmazonKinesis kinesisClient = Whitebox.getInternalState(proxy, 
"kinesisClient");
                ClientConfiguration clientConfiguration = 
Whitebox.getInternalState(kinesisClient,
    -                   "clientConfiguration");
    +                                           "clientConfiguration");
                assertEquals(9999, clientConfiguration.getSocketTimeout());
        }
    -
    --- End diff --
    
    Done. Sorry for the inconvenience.


> Use ListShards for shard discovery in the flink kinesis connector
> -----------------------------------------------------------------
>
>                 Key: FLINK-8944
>                 URL: https://issues.apache.org/jira/browse/FLINK-8944
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Kailash Hassan Dayanand
>            Priority: Minor
>
> Currently the DescribeStream AWS API used to get list of shards is has a 
> restricted rate limits on AWS. (5 requests per sec per account). This is 
> problematic when running multiple flink jobs all on same account since each 
> subtasks calls the Describe Stream. Changing this to ListShards will provide 
> more flexibility on rate limits as ListShards has a 100 requests per second 
> per data stream limits.
> More details on the mailing list. https://goo.gl/mRXjKh



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to