Github user kailashhd commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5992#discussion_r188481562
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
 ---
    @@ -65,14 +65,14 @@ public SentinelSequenceNumber 
toSentinelSequenceNumber() {
        /** The date format of initial timestamp to start reading Kinesis 
stream from (when AT_TIMESTAMP is set for STREAM_INITIAL_POSITION). */
        public static final String STREAM_TIMESTAMP_DATE_FORMAT = 
"flink.stream.initpos.timestamp.format";
     
    -   /** The base backoff time between each describeStream attempt. */
    -   public static final String STREAM_DESCRIBE_BACKOFF_BASE = 
"flink.stream.describe.backoff.base";
    --- End diff --
    
    I have deprecated some old properties and added the new ones. This is my 
first time using the @deprecated annotations. Do let me know if there are 
better ways of doing this. I used sample PRs like https://goo.gl/LWcrp2 for 
these changes. 
    
    



---

Reply via email to