Github user tweise commented on a diff in the pull request:
https://github.com/apache/flink/pull/5992#discussion_r188481796
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -181,6 +181,25 @@ public static Properties
replaceDeprecatedProducerKeys(Properties configProps) {
return configProps;
}
+ public static Properties replaceDeprecatedConsumerKeys(Properties
configProps) {
+ if
(configProps.containsKey(ConsumerConfigConstants.STREAM_DESCRIBE_BACKOFF_BASE))
{
--- End diff --
Minor: this could be generalized by iterating over a map of oldkey ->
newkey and I would also suggest to log a warning for deprecated keys
---
