Github user snuyanzin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6040#discussion_r189035401
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
 ---
    @@ -507,7 +507,7 @@ private void updateMinPunctuatedWatermark(Watermark 
nextWatermark) {
                        SerializedValue<AssignerWithPunctuatedWatermarks<T>> 
watermarksPunctuated,
                        ClassLoader userCodeClassLoader) throws IOException, 
ClassNotFoundException {
     
    -           List<KafkaTopicPartitionState<KPH>> partitionStates = new 
LinkedList<>();
    +           List<KafkaTopicPartitionState<KPH>> partitionStates = new 
CopyOnWriteArrayList<>();
    --- End diff --
    
    Yes you are right. A question: is it allowed to specify a link on the issue 
comment where it was decided to use CopyOnWriteArrayList? Or is it better to 
have explanation in a comment only?


---

Reply via email to