Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6040#discussion_r190112933
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
@@ -507,7 +507,11 @@ private void updateMinPunctuatedWatermark(Watermark
nextWatermark) {
SerializedValue<AssignerWithPunctuatedWatermarks<T>>
watermarksPunctuated,
ClassLoader userCodeClassLoader) throws IOException,
ClassNotFoundException {
- List<KafkaTopicPartitionState<KPH>> partitionStates = new
LinkedList<>();
+ /**
+ * CopyOnWrite as adding discovered partitions could happen in
parallel
+ * with different threads iterating by {@link
AbstractFetcher#subscribedPartitionStates} results
+ */
--- End diff --
I think we usually don't have Javadoc blocks within methods. A regular
comment with `//` would do.
---
