ASF GitHub Bot commented on FLINK-9326:

GitHub user yanghua opened a pull request:


    [FLINK-9326] TaskManagerOptions.NUM_TASK_SLOTS does not work for 
local/embedded mode

    ## What is the purpose of the change
    *This pull request fixed the num slot config value override error.*
    ## Brief change log
      - *fixed the num slot config value override error.*
    ## Verifying this change
    This change is already covered by existing tests*.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    ## Documentation
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-9326

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6041
commit 16fb81beaa4983a04e9929267ced36a3121f8188
Author: yanghua <yanghua1127@...>
Date:   2018-05-18T06:36:19Z

    [FLINK-9326] TaskManagerOptions.NUM_TASK_SLOTS does not work for 
local/embedded mode


> TaskManagerOptions.NUM_TASK_SLOTS does not work for local/embedded mode
> -----------------------------------------------------------------------
>                 Key: FLINK-9326
>                 URL: https://issues.apache.org/jira/browse/FLINK-9326
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.5.0
>         Environment: Linux 64bit
> Flink branch release-1.5
>            Reporter: Samuel Doyle
>            Assignee: vinoyang
>            Priority: Major
> When attempting to set the number of task slots via the api such ash
> {code:java}
> configuration = new Configuration();
> configuration.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, 16);
> configuration.setInteger(CoreOptions.DEFAULT_PARALLELISM, 1);
> {code}
> I will always end up with the default slot setting based on the number of 
> cores I have where my standalone instance is running, it doesn't matter what 
> I set the the NUM_TASK_SLOTS to, it has no effect

This message was sent by Atlassian JIRA

Reply via email to