Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6040#discussion_r190111529
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java
 ---
    @@ -416,9 +520,16 @@ protected TestFetcher(
                                false);
                }
     
    +           /**
    +            * Emulation of partition's iteration which is required for
    +            * {@link 
AbstractFetcherTest#testConcurrentPartitionsDiscoveryAndLoopFetching}.
    +            * @throws Exception
    +            */
                @Override
                public void runFetchLoop() throws Exception {
    -                   throw new UnsupportedOperationException();
    +                   for (KafkaTopicPartitionState ignored: 
subscribedPartitionStates()) {
    +                           Thread.sleep(10L);
    --- End diff --
    
    This would only let the test fail "occasionally", right?
    I would like this to be changed, so that we always have the test failing 
without the copy on write fix.
    We could do this by having a dummy source context that blocks on record 
emit.


---

Reply via email to