[GitHub] flink pull request #6007: [FLINK-8518][Table API & SQL] Support DOW for EXTR...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6007#discussion_r190226613
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
 ---
    @@ -1473,6 +1473,14 @@ class ScalarFunctionsTest extends 
ScalarTypesTestBase {
           "EXTRACT(DOY FROM f16)",
           "315")
     
    +    testSqlApi(
    +      "EXTRACT(DOW FROM f18)",
    +      "1")
    +
    +    testSqlApi(
    +      "EXTRACT(DOW FROM f16)",
    --- End diff --
    
    Can you add a test (maybe in `ScalarFunctionsValidationTest`?) for checking 
the behavior on a `TIME` type? 


---