[
https://issues.apache.org/jira/browse/FLINK-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487173#comment-16487173
]
ASF GitHub Bot commented on FLINK-8518:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6007#discussion_r190226613
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -1473,6 +1473,14 @@ class ScalarFunctionsTest extends
ScalarTypesTestBase {
"EXTRACT(DOY FROM f16)",
"315")
+ testSqlApi(
+ "EXTRACT(DOW FROM f18)",
+ "1")
+
+ testSqlApi(
+ "EXTRACT(DOW FROM f16)",
--- End diff --
Can you add a test (maybe in `ScalarFunctionsValidationTest`?) for checking
the behavior on a `TIME` type?
> Support DOW, EPOCH, DECADE for EXTRACT
> --------------------------------------
>
> Key: FLINK-8518
> URL: https://issues.apache.org/jira/browse/FLINK-8518
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Sergey Nuyanzin
> Priority: Major
>
> We upgraded Calcite to version 1.15 in FLINK-7934. The EXTRACT method
> supports more conversion targets. The targets DOW, EPOCH, DECADE should be
> implemented and tested for different datatypes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
