[
https://issues.apache.org/jira/browse/FLINK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487270#comment-16487270
]
ASF GitHub Bot commented on FLINK-9386:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/6031#discussion_r190246117
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
---
@@ -89,19 +91,20 @@ public RuntimeMonitorHandler(
}
@Override
- protected void respondAsLeader(ChannelHandlerContext ctx, Routed
routed, JobManagerGateway jobManagerGateway) {
+ protected void respondAsLeader(ChannelHandlerContext ctx, RoutedRequest
routedRequest, JobManagerGateway jobManagerGateway) {
CompletableFuture<FullHttpResponse> responseFuture;
+ RouteResult result = routedRequest.getRouteResult();
--- End diff --
I think if you do `RouteResult<?> result = routedRequest.getRouteResult();`
you don't need the cast to `Set<String>` in lines 101 and 106.
> Remove netty-router dependency
> ------------------------------
>
> Key: FLINK-9386
> URL: https://issues.apache.org/jira/browse/FLINK-9386
> Project: Flink
> Issue Type: Sub-task
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Fix For: 1.6.0
>
>
> netty-router 1.10 blocks upgrade to 4.1, while netty-router 2.2.0 has broken
> compatibility in a way that it's unusable by us (it doesn't allow to sort
> router paths as in https://issues.apache.org/jira/browse/FLINK-8000 ). I
> propose to copy & simplify & modify netty-router code to suite our needs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
