[
https://issues.apache.org/jira/browse/FLINK-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490388#comment-16490388
]
ASF GitHub Bot commented on FLINK-9436:
---------------------------------------
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/6077
FLINK-9436][state] Remove generic parameter namespace from
InternalTimeServiceManager
## Brief change log
This PR removes the misleading generic parameter `N` from
`InternalTimerServiceManager<K, N>`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink generics-refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6077.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6077
----
commit fffc7ff6750509de2c97ea7ed44d2404669acd35
Author: Stefan Richter <s.richter@...>
Date: 2018-05-08T14:00:55Z
[FLINK-9423][state] Implement efficient deletes for heap-based timer
service.
commit a8e0f2f6bf4343938819e2e9a3b7ea29e94d0fc0
Author: Stefan Richter <s.richter@...>
Date: 2018-05-23T15:39:47Z
review comments
commit 4fc37152905f80ba2c6db2d0fdc08273a751c34b
Author: Stefan Richter <s.richter@...>
Date: 2018-05-24T13:08:02Z
[FLINK-9436][state] Remove generic parameter namespace from
InternalTimeServiceManager.
----
> Remove generic parameter namespace from InternalTimeServiceManager
> ------------------------------------------------------------------
>
> Key: FLINK-9436
> URL: https://issues.apache.org/jira/browse/FLINK-9436
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Minor
> Fix For: 1.6.0
>
>
> Currently {{InternalTimeServiceManager<K, N>}} declares a generic parameter
> {{N}} for namespace. This parameter is not useful or even misleading, because
> in the current implementation the managed timer services can all have
> different types for their {{N}}. I suggest to remove the parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
