[ 
https://issues.apache.org/jira/browse/FLINK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490456#comment-16490456
 ] 

ASF GitHub Bot commented on FLINK-9091:
---------------------------------------

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/6073
  
    Converging dependencies by enforcing their versions in root's pom 
`dependencyManagement` section is the way that we have chosen previously, so it 
would be more consistent. 
    
    https://issues.apache.org/jira/browse/FLINK-7765
    https://github.com/apache/flink/pull/4777
    
    Thus I would put `janino`'s entries in root pom. Open question is what to 
do with `guava` since I do not know if this comment in root pom is still valid 
after 3 years and what was it all about:
    ```
        <dependencyManagement>
                <!-- WARN:
                        DO NOT put      guava,
                                                protobuf,
                                                asm,
                                                netty
                                        here. It will overwrite Hadoop's guava 
dependency (even though we handle it
                        separatly in the flink-shaded-hadoop module).
                -->
    ```


> Failure while enforcing releasability in building flink-json module
> -------------------------------------------------------------------
>
>                 Key: FLINK-9091
>                 URL: https://issues.apache.org/jira/browse/FLINK-9091
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>            Reporter: Ted Yu
>            Assignee: Hai Zhou
>            Priority: Major
>         Attachments: f-json.out
>
>
> Got the following when building flink-json module:
> {code}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence 
> failed with message:
> Failed while enforcing releasability. See above detailed error message.
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce 
> (dependency-convergence) on project flink-json: Some Enforcer rules have 
> failed.   Look above for specific messages explaining why the rule failed. -> 
> [Help 1]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to