[
https://issues.apache.org/jira/browse/FLINK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493616#comment-16493616
]
ASF GitHub Bot commented on FLINK-9423:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191445752
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimersSnapshotReaderWriters.java
---
@@ -96,7 +96,7 @@ public
AbstractInternalTimersSnapshotWriter(InternalTimersSnapshot<K, N> timersS
public final void writeTimersSnapshot(DataOutputView out)
throws IOException {
writeKeyAndNamespaceSerializers(out);
- InternalTimer.TimerSerializer<K, N> timerSerializer =
new InternalTimer.TimerSerializer<>(
+ TimerHeapInternalTimer.TimerSerializer<K, N>
timerSerializer = new TimerHeapInternalTimer.TimerSerializer<>(
--- End diff --
Isn't this a bit problematic if we add a new `TimerService` implementation
other than the `HeapInternalTimerService`? The `InternalTimersSnapshot` is
independent of the underlying timer service implementation and so should the
timer serializer be.
> Implement efficient deletes for heap based timer service
> --------------------------------------------------------
>
> Key: FLINK-9423
> URL: https://issues.apache.org/jira/browse/FLINK-9423
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 1.5.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Fix For: 1.6.0
>
>
> The current data structures in the `HeapInternalTimerService` are not able to
> support efficient timer deletes, the complexity is currently O\(n\), where n
> is the number of registered timers.
>
> We can keep track of timer's positions in the priority queue and (in
> combination with the already existing set/map) have a more efficient
> algorithm for deletes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
