Github user kisimple commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6091#discussion_r191835482
  
    --- Diff: 
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala
 ---
    @@ -71,6 +71,9 @@ object AsyncDataStream {
           override def asyncInvoke(input: IN, resultFuture: 
JavaResultFuture[OUT]): Unit = {
             asyncFunction.asyncInvoke(input, new 
JavaResultFutureWrapper(resultFuture))
           }
    +      override def timeout(input: IN, resultFuture: 
JavaResultFuture[OUT]): Unit = {
    --- End diff --
    
    I haven't found any tests for `AsyncDataStream.scala` or 
`AsyncFunction.scala`, I am not sure whether it is missing or unnecessary. What 
do you think?


---

Reply via email to