Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192028605
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala
---
@@ -71,6 +71,9 @@ object AsyncDataStream {
override def asyncInvoke(input: IN, resultFuture:
JavaResultFuture[OUT]): Unit = {
asyncFunction.asyncInvoke(input, new
JavaResultFutureWrapper(resultFuture))
}
+ override def timeout(input: IN, resultFuture:
JavaResultFuture[OUT]): Unit = {
--- End diff --
You are right, there are none :( They are definitely missing, however
simple this code is. I know this is painful but still I would insist on adding
at least some rudimentary test coverage for the new code. As it is now, if
someone would change the below invocation to `asyncFunction.timeout(null,
null)` we wouldn't have known.
Let's try to improve the situation here a little bit. The new test doesn't
have to duplicate the test cases from `AsyncWaitOperatorTest.java`, but some
most basic one that checks that expected arguments are being passed will
suffice.
---
