[ 
https://issues.apache.org/jira/browse/FLINK-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497911#comment-16497911
 ] 

ASF GitHub Bot commented on FLINK-9476:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6104#discussion_r192376031
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
    @@ -383,6 +386,100 @@ public String select(Map<String, List<Event>> 
pattern) {
                env.execute();
        }
     
    +   @Test
    +   public void testSimpleKeyedPatternEventTimeWithSideOutput() throws 
Exception {
    --- End diff --
    
    How about to simplify the test a bit? 
    
    I would be in favour of implementing this test with `OperatorTestHarness` 
(in CepOperatorTest). This way we it is way easier to follow which events are 
late.
    
    Also I would use a simpler Pattern here... Don't see a reason for using 3 
part one.


> Lost sideOutPut Late Elements in CEP Operator
> ---------------------------------------------
>
>                 Key: FLINK-9476
>                 URL: https://issues.apache.org/jira/browse/FLINK-9476
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.4.2
>            Reporter: aitozi
>            Assignee: aitozi
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to