[ 
https://issues.apache.org/jira/browse/FLINK-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500220#comment-16500220
 ] 

ASF GitHub Bot commented on FLINK-9476:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6104#discussion_r192742897
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CepOperatorTestUtilities.java
 ---
    @@ -66,6 +68,9 @@ public Integer getKey(Event value) throws Exception {
                boolean isProcessingTime,
                NFACompiler.NFAFactory<Event> nfaFactory,
                EventComparator<Event> comparator) {
    +
    +           OutputTag<Event> lateDataTag = new 
OutputTag<Event>("late-data", TypeInformation.of(Event.class));
    --- End diff --
    
    Could you pass it as parameter? And by default set a null one? I would 
prefer that we do not depend on the fact that the name in here and in the test 
are the same. Would prefer using the same object.


> Lost sideOutPut Late Elements in CEP Operator
> ---------------------------------------------
>
>                 Key: FLINK-9476
>                 URL: https://issues.apache.org/jira/browse/FLINK-9476
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.4.2
>            Reporter: aitozi
>            Assignee: aitozi
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to