Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5448
  
    Okay, after taking a look, I think we need to add a few changes:
    
      - We need to add an additional `MemoryUnit.parse()` method that takes the 
"default" unit, so that we parse the old heap sizes such that they are in MB if 
nothing else is specified.
    
      - We should either change the return value of `getMebiBytes()` to `int` 
or have a `getMebiBytesAsInt()` method that uses a 
`MathUtils.checkedDownCast()` to avoid unnoticed overflow errors.
    
    Open question: As we are changing the value type of the heap size config 
options, should we deprecate the current config keys and introduce new ones 
(like `jobmanager.heap-size`)?



---

Reply via email to