[ 
https://issues.apache.org/jira/browse/FLINK-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500221#comment-16500221
 ] 

ASF GitHub Bot commented on FLINK-9476:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6104#discussion_r192741842
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java
 ---
    @@ -726,6 +727,50 @@ public void 
testCEPOperatorCleanupEventTimeWithSameElements() throws Exception {
                }
        }
     
    +   @Test
    +   public void testCEPOperatorSideOutputLateElementsEventTime() throws 
Exception {
    +
    +           Event startEvent = new Event(41, "c", 1.0);
    +           Event middle1Event1 = new Event(41, "a", 2.0);
    +           Event middle1Event2 = new Event(41, "a", 3.0);
    +           Event middle1Event3 = new Event(41, "a", 4.0);
    +
    +           SelectCepOperator<Event, Integer, Map<String, List<Event>>> 
operator = CepOperatorTestUtilities.getKeyedCepOpearator(
    +                   false,
    +                   new ComplexNFAFactory());
    +           OneInputStreamOperatorTestHarness<Event, Map<String, 
List<Event>>> harness = CepOperatorTestUtilities.getCepTestHarness(operator);
    +
    +           try {
    --- End diff --
    
    Could you switch it to `try-with-resources` block? I know there is a lot 
tests in that style, but we should add new tests with a proper style ;)


> Lost sideOutPut Late Elements in CEP Operator
> ---------------------------------------------
>
>                 Key: FLINK-9476
>                 URL: https://issues.apache.org/jira/browse/FLINK-9476
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.4.2
>            Reporter: aitozi
>            Assignee: aitozi
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to