[jira] [Commented] (FLINK-8468) Make the connector to take advantage of AMQP features (routing key, exchange and message properties)

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501996#comment-16501996
 ] 

ASF GitHub Bot commented on FLINK-8468:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r193126169
  
    --- Diff: 
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
 ---
    @@ -83,7 +103,22 @@ public void throwExceptionIfChannelIsNull() throws 
Exception {
        }
     
        private RMQSink<String> createRMQSink() throws Exception {
    -           RMQSink rmqSink = new RMQSink<String>(rmqConnectionConfig, 
QUEUE_NAME, serializationSchema);
    +           RMQSink<String> rmqSink = new 
RMQSink<String>(rmqConnectionConfig, QUEUE_NAME, serializationSchema);
    +           rmqSink.open(new Configuration());
    +           return rmqSink;
    +   }
    +
    +   private RMQSink<String> createRMQSinkFeatured() throws Exception {
    +           publishOptions = new DummyPublishOptions();
    +           RMQSink<String> rmqSink = new 
RMQSink<String>(rmqConnectionConfig, serializationSchema, publishOptions);
    +           rmqSink.open(new Configuration());
    +           return rmqSink;
    +   }
    +
    +   private RMQSink<String> createRMQSinkFeaturedReturnHandler() throws 
Exception {
    +           publishOptions = new DummyPublishOptions();
    +           returnListener = new DummyReturnHandler();
    +           RMQSink<String> rmqSink = new 
RMQSink<String>(rmqConnectionConfig, serializationSchema, publishOptions, 
returnListener);
    --- End diff --
    
    nit: Java 7 diamond operator should be preferred, i.e., `new RMQSink<>(...)`


> Make the connector to take advantage of AMQP features (routing key, exchange 
> and message properties)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8468
>                 URL: https://issues.apache.org/jira/browse/FLINK-8468
>             Project: Flink
>          Issue Type: Improvement
>          Components: RabbitMQ Connector
>    Affects Versions: 1.4.0
>            Reporter: Ph.Duveau
>            Priority: Major
>
> Make the connector to take advantage of AMQP features by adding a constructor 
> and an interface to implement



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)