[jira] [Commented] (FLINK-8468) Make the connector to take advantage of AMQP features (routing key, exchange and message properties)

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501986#comment-16501986
 ] 

ASF GitHub Bot commented on FLINK-8468:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r193070753
  
    --- Diff: 
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
 ---
    @@ -66,12 +79,19 @@ public void before() throws Exception {
        }
     
        @Test
    -   public void openCallDeclaresQueue() throws Exception {
    +   public void openCallDeclaresQueueInStandardMode() throws Exception {
                createRMQSink();
     
                verify(channel).queueDeclare(QUEUE_NAME, false, false, false, 
null);
        }
     
    +   @Test
    +   public void openCallDontDeclaresQueueInFeaturedMode() throws Exception {
    +           doThrow(Exception.class).when(channel).queueDeclare(null, 
false, false, false, null);
    --- End diff --
    
    There is no assertion in this test. I would re-write it as:
    ```
        @Test
        public void openCallDontDeclaresQueueInFeaturedMode() throws Exception {
                createRMQSinkFeatured();
    
                verify(channel, never()).queueDeclare(null, false, false, 
false, null);
        }
    ```


> Make the connector to take advantage of AMQP features (routing key, exchange 
> and message properties)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8468
>                 URL: https://issues.apache.org/jira/browse/FLINK-8468
>             Project: Flink
>          Issue Type: Improvement
>          Components: RabbitMQ Connector
>    Affects Versions: 1.4.0
>            Reporter: Ph.Duveau
>            Priority: Major
>
> Make the connector to take advantage of AMQP features by adding a constructor 
> and an interface to implement



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)