[
https://issues.apache.org/jira/browse/FLINK-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504515#comment-16504515
]
ASF GitHub Bot commented on FLINK-9503:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6129#discussion_r193701993
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java
---
@@ -117,7 +107,9 @@ public boolean filter(Long value) throws Exception {
}
}).withBroadcastSet(solution, "SOLUTION")).output(new
DiscardingOutputFormat<Long>());
env.execute();
- expected = testString; // this will be a useless verification
now.
+ String expected = testString; // this will be a useless
verification now.
+
+ compareResultsByLinesInMemory(expected, resultPath);
--- End diff --
this is unnecessary and can be removed as the actual check is done in the
function.
> Migrate integration tests for iterative aggregators
> ---------------------------------------------------
>
> Key: FLINK-9503
> URL: https://issues.apache.org/jira/browse/FLINK-9503
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Deepak Sharma
> Assignee: vinoyang
> Priority: Minor
>
> Migrate integration tests inĀ org.apache.flink.test.iterative.aggregators to
> use collect() instead of temp files. Related to parent jira.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)