[ 
https://issues.apache.org/jira/browse/FLINK-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504518#comment-16504518
 ] 

ASF GitHub Bot commented on FLINK-9503:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6129#discussion_r193702401
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java
 ---
    @@ -170,12 +162,12 @@ public void testAggregatorWithParameterForIterate() 
throws Exception {
                                new NegativeElementsConvergenceCriterion());
     
                DataSet<Integer> updatedDs = iteration.map(new 
SubtractOneMapWithParam());
    -           iteration.closeWith(updatedDs).writeAsText(resultPath);
    -           env.execute();
    +           List<Integer> result = iteration.closeWith(updatedDs).collect();
    +           Collections.sort(result);
    --- End diff --
    
    still some sort calls left.


> Migrate integration tests for iterative aggregators
> ---------------------------------------------------
>
>                 Key: FLINK-9503
>                 URL: https://issues.apache.org/jira/browse/FLINK-9503
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Deepak Sharma
>            Assignee: vinoyang
>            Priority: Minor
>
> Migrate integration tests inĀ org.apache.flink.test.iterative.aggregators to 
> use collect() instead of temp files. Related to parent jira.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to