Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194713008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RoutedRequest.java
---
@@ -97,11 +98,17 @@ public ReferenceCounted retain(int arg0) {
@Override
public ReferenceCounted touch() {
+ if (requestAsReferenceCounted.isPresent()) {
+
ReferenceCountUtil.touch(requestAsReferenceCounted.get());
+ }
return this;
}
@Override
public ReferenceCounted touch(Object o) {
+ if (requestAsReferenceCounted.isPresent()) {
+
ReferenceCountUtil.touch(requestAsReferenceCounted.get());
--- End diff --
I think we could do that. I'm not entirely sure how this whole `touch` is
suppose to work, but passing down the hint shouldn't harm anything and be more
correct.
---