[
https://issues.apache.org/jira/browse/FLINK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511250#comment-16511250
]
ASF GitHub Bot commented on FLINK-9572:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r195111820
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
---
@@ -237,4 +249,20 @@ public void addAll(List<V> values) throws Exception {
return keySerializationStream.toByteArray();
}
+
+ @Override
+ public List<V> getInternal() {
+ Iterable<V> list = get();
+ if (list == null) {
+ return null;
+ }
+ List<V> collected = new ArrayList<>();
--- End diff --
We could currently also safe the whole repacking if we change the signature
of `Iterable<V> get()` in this class to return ``List<V>``.
However, I think in the long run it might be worth considering to have this
class be based on `Iterable` instead of `List` because we essentially only use
iterable semantics. @aljoscha what do you think?
> Extend InternalAppendingState with internal stored state access
> ---------------------------------------------------------------
>
> Key: FLINK-9572
> URL: https://issues.apache.org/jira/browse/FLINK-9572
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Andrey Zagrebin
> Assignee: Andrey Zagrebin
> Priority: Major
> Fix For: 1.6.0
>
>
>
> {code:java}
> public interface InternalAppendingState<K, N, IN, SV, OUT> ... {
> SV getInternal();
> void updateInternal(SV);
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
