[ 
https://issues.apache.org/jira/browse/FLINK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511315#comment-16511315
 ] 

ASF GitHub Bot commented on FLINK-9572:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6156#discussion_r195136079
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalAppendingState.java
 ---
    @@ -31,4 +31,22 @@
      * @param <SV> The type of elements in the state
      * @param <OUT> The type of the resulting element in the state
      */
    -public interface InternalAppendingState<K, N, IN, SV, OUT> extends 
InternalKvState<K, N, SV>, AppendingState<IN, OUT> {}
    +public interface InternalAppendingState<K, N, IN, SV, OUT> extends 
InternalKvState<K, N, SV>, AppendingState<IN, OUT> {
    --- End diff --
    
    I had a second thought about this and I think just adding the methods only 
in `InternalAppendingState` might be a better choice in the end, because it 
feels only required here to have a way of manipulating the internal type. Sorry 
for that :)


> Extend InternalAppendingState with internal stored state access
> ---------------------------------------------------------------
>
>                 Key: FLINK-9572
>                 URL: https://issues.apache.org/jira/browse/FLINK-9572
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.6.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>             Fix For: 1.6.0
>
>
>  
> {code:java}
> public interface InternalAppendingState<K, N, IN, SV, OUT> ... {
>     SV getInternal();
>     void updateInternal(SV);
> }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to