[
https://issues.apache.org/jira/browse/FLINK-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512265#comment-16512265
]
ASF GitHub Bot commented on FLINK-9584:
---------------------------------------
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6164
[FLINK-9584][connector] Properly close the output stream in BucketingSink &
RollingSink.
## What is the purpose of the change
This PR fixes the unclosed streams in Bucketing-/RollingSink.
## Brief change log
- *Properly close the output stream in BucketingSink & RollingSink.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
No
## Documentation
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sihuazhou/flink FLINK-9584
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6164
----
commit 5954d442c56bbf889a3cd80d893e7ee0fe83e60f
Author: sihuazhou <summerleafs@...>
Date: 2018-06-14T10:12:20Z
Properly close the output stream in BucketingSink & RollingSink.
----
> Unclosed streams in Bucketing-/RollingSink
> ------------------------------------------
>
> Key: FLINK-9584
> URL: https://issues.apache.org/jira/browse/FLINK-9584
> Project: Flink
> Issue Type: Bug
> Components: filesystem-connector
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Sihua Zhou
> Priority: Major
>
> There are 4 instances of {{FSDataOutputStream}} that are not properly closed
> in the {{BucketingSink}} (2) and {{RollingSink}} (2).
>
> [https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java#L536]
>
> [https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java#L705]
>
> [https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java#L638]
> [https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java#882]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
