[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

[StefanRRichter]

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6208#discussion_r198122538
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java 
---
    @@ -280,12 +281,7 @@ public JobMaster(
     
                resourceManagerLeaderRetriever = 
highAvailabilityServices.getResourceManagerLeaderRetriever();
     
    -           this.slotPool = new SlotPool(
    -                   rpcService,
    -                   jobGraph.getJobID(),
    -                   SystemClock.getInstance(),
    -                   rpcTimeout,
    -                   jobMasterConfiguration.getSlotIdleTimeout());
    +           this.slotPool = 
checkNotNull(slotPoolFactory).createSlotPool(jobGraph.getJobID());
    --- End diff --
    
    After that, I also wonder if the factory still makes sense because we 
statically always use the same concrete implementation.


---