Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6208#discussion_r198129120
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultSlotPoolFactory.java
---
@@ -75,10 +82,21 @@ public static DefaultSlotPoolFactory fromConfiguration(
final Time rpcTimeout =
AkkaUtils.getTimeoutAsTime(configuration);
final Time slotIdleTimeout =
Time.milliseconds(configuration.getLong(JobManagerOptions.SLOT_IDLE_TIMEOUT));
+ final SchedulingStrategy schedulingStrategy =
selectSchedulingStrategy(configuration);
+
return new DefaultSlotPoolFactory(
rpcService,
+ schedulingStrategy,
SystemClock.getInstance(),
rpcTimeout,
slotIdleTimeout);
}
+
+ private static SchedulingStrategy
selectSchedulingStrategy(Configuration configuration) {
+ if
(configuration.getBoolean(CheckpointingOptions.LOCAL_RECOVERY)) {
+ return
PreviousAllocationSchedulingStrategy.getInstance();
+ } else {
+ return
LocationPreferenceSchedulingStrategy.getInstance();
--- End diff --
Does it make sense to use the `LocationPreferenceSchedulingStrategy` for
the init scheduling even when the "local recovery" is enable?
---
