[
https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524007#comment-16524007
]
ASF GitHub Bot commented on FLINK-8866:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r198207327
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/connector/TableSinkFactoryServiceTest.scala
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector
+
+import org.apache.flink.table.api.{NoMatchingTableConnectorException,
TableException, ValidationException}
+import org.apache.flink.table.descriptors.ConnectorDescriptorValidator._
+import org.apache.flink.table.descriptors.FormatDescriptorValidator._
+import org.apache.flink.table.descriptors.TableDescriptorValidator
+import org.junit.Assert._
+import org.junit.Test
+
+import scala.collection.mutable
+
+class TableSinkFactoryServiceTest {
+ @Test
+ def testValidProperties(): Unit = {
+ val props = properties()
+
assertTrue(TableSinkFactoryService.findAndCreateTableConnector(props.toMap) !=
null)
+ }
+
+ @Test(expected = classOf[NoMatchingTableConnectorException])
+ def testInvalidContext(): Unit = {
+ val props = properties()
+ props.put(CONNECTOR_TYPE, "FAIL")
+ TableSinkFactoryService.findAndCreateTableConnector(props.toMap)
+ }
+
+ @Test
+ def testDifferentContextVersion(): Unit = {
+ val props = properties()
+ props.put(CONNECTOR_PROPERTY_VERSION, "2")
+ // the table source should still be found
+
assertTrue(TableSinkFactoryService.findAndCreateTableConnector(props.toMap) !=
null)
+ }
+
+ @Test(expected = classOf[ValidationException])
+ def testUnsupportedProperty(): Unit = {
+ val props = properties()
+ props.put("format.path_new", "/new/path")
+ TableSinkFactoryService.findAndCreateTableConnector(props.toMap)
+ }
+
+ @Test(expected = classOf[TableException])
+ def testFailingFactory(): Unit = {
+ val props = properties()
+ props.put("failing", "true")
+ TableSinkFactoryService.findAndCreateTableConnector(props.toMap)
+ }
+
+ private def properties(): mutable.Map[String, String] = {
+ val properties = mutable.Map[String, String]()
+ properties.put(TableDescriptorValidator.TABLE_TYPE,
+ TableDescriptorValidator.TABLE_TYPE_VALUE_SINK)
+ properties.put(CONNECTOR_TYPE, "test")
--- End diff --
I would use strings here for everything (not the variables). This allows
tests to fail if we refactor one of the properties.
> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>
> Key: FLINK-8866
> URL: https://issues.apache.org/jira/browse/FLINK-8866
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> Similar to the efforts done in FLINK-8240. We need unified ways to configure
> and instantiate TableSinks. Among other applications, this is necessary in
> order to declare table sinks in an environment file of the SQL client. Such
> that the sink can be used for {{INSERT INTO}} statements.
> Below are a few major changes in mind.
> 1) Add TableSinkFactory/TableSinkFactoryService similar to
> TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both)
> for both TableSource and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to
> identify whether it's source or sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
