[
https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527246#comment-16527246
]
ASF GitHub Bot commented on FLINK-8866:
---------------------------------------
Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r199065915
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -321,6 +327,18 @@ public void stop(SessionContext session) {
}
}
+ private <T> void executeUpdateInternal(ExecutionContext<T> context,
String query) {
+ final ExecutionContext.EnvironmentInstance envInst =
context.createEnvironmentInstance();
+
+ envInst.getTableEnvironment().sqlUpdate(query);
+ // create job graph with dependencies
+ final String jobName = context.getSessionContext().getName() +
": " + query;
+ final JobGraph jobGraph = envInst.createJobGraph(jobName);
+
+ // create execution
+ new Thread(new ProgramDeployer<>(context, jobName, jobGraph,
null)).start();
--- End diff --
@twalthr, for sink only table, I dont think the user need to define any
rowtimes on it, since it will never use as a source. For table as both source
and sink, when registering it as sink, I think we only need to take care of the
'from-field' columns, since they map to actual data fields in the table. For
`proctime` and 'from-source' columns, we can just ignore them when building the
sink schema. Maybe, we should have some helper method for building the schema
for source and sink separately. Please correct me if I missed something here.
What do you think?
> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>
> Key: FLINK-8866
> URL: https://issues.apache.org/jira/browse/FLINK-8866
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> Similar to the efforts done in FLINK-8240. We need unified ways to configure
> and instantiate TableSinks. Among other applications, this is necessary in
> order to declare table sinks in an environment file of the SQL client. Such
> that the sink can be used for {{INSERT INTO}} statements.
> Below are a few major changes in mind.
> 1) Add TableSinkFactory/TableSinkFactoryService similar to
> TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both)
> for both TableSource and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to
> identify whether it's source or sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
