[
https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527653#comment-16527653
]
ASF GitHub Bot commented on FLINK-8866:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6201
Hi, I think timestamp fields of source-sink tables should be handled as
follows when emitting the table:
- `proc-time`: ignore
- `from-field`: simply write out the timestamp as part of the row.
- `from-source`: write the timestamp separately to the system and remove it
from the row. This only works if we can set the timestamp to the sink system.
If the system sets the ingestion timestamp by it own, i.e., not the actual
value, rows would contain different timestamps when they are ingested. If the
sink system does not support to set a timestamp, we cannot allow such a table
definition.
> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>
> Key: FLINK-8866
> URL: https://issues.apache.org/jira/browse/FLINK-8866
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> Similar to the efforts done in FLINK-8240. We need unified ways to configure
> and instantiate TableSinks. Among other applications, this is necessary in
> order to declare table sinks in an environment file of the SQL client. Such
> that the sink can be used for {{INSERT INTO}} statements.
> Below are a few major changes in mind.
> 1) Add TableSinkFactory/TableSinkFactoryService similar to
> TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both)
> for both TableSource and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to
> identify whether it's source or sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
