Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-126304357
Thanks for the update @r-pogalz and @jkovacs!
Looks really good. I would like to ask you for one more favor. As you might
know, Join was previously called Match and the name was changed quite some time
ago. All public interfaces were updated but the name Match lives on in many
places in the internals. It would be great if you could update `match` to
`join` in the classes that you rewrite (esp. in JavaDocs and parameter names).
I started adding comments for that, but stopped at one point.
@r-pogalz looking forward to the microbenchmark!
Thank you, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---