[
https://issues.apache.org/jira/browse/FLINK-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647536#comment-14647536
]
ASF GitHub Bot commented on FLINK-2105:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-126304357
Thanks for the update @r-pogalz and @jkovacs!
Looks really good. I would like to ask you for one more favor. As you might
know, Join was previously called Match and the name was changed quite some time
ago. All public interfaces were updated but the name Match lives on in many
places in the internals. It would be great if you could update `match` to
`join` in the classes that you rewrite (esp. in JavaDocs and parameter names).
I started adding comments for that, but stopped at one point.
@r-pogalz looking forward to the microbenchmark!
Thank you, Fabian
> Implement Sort-Merge Outer Join algorithm
> -----------------------------------------
>
> Key: FLINK-2105
> URL: https://issues.apache.org/jira/browse/FLINK-2105
> Project: Flink
> Issue Type: Sub-task
> Components: Local Runtime
> Reporter: Fabian Hueske
> Assignee: Ricky Pogalz
> Priority: Minor
> Fix For: pre-apache
>
>
> Flink does not natively support outer joins at the moment.
> This issue proposes to implement a sort-merge outer join algorithm that can
> cover left, right, and full outer joins.
> The implementation can be based on the regular sort-merge join iterator
> ({{ReusingMergeMatchIterator}} and {{NonReusingMergeMatchIterator}}, see also
> {{MatchDriver}} class)
> The Reusing and NonReusing variants differ in whether object instances are
> reused or new objects are created. I would start with the NonReusing variant
> which is safer from a user's point of view and should also be easier to
> implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
