[ 
https://issues.apache.org/jira/browse/FLINK-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651096#comment-14651096
 ] 

ASF GitHub Bot commented on FLINK-2105:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/907#issuecomment-127047952
  
    For most other tests that we have added/reworked in the past, we moved away 
from using `Record` for the tests. The `Record` was the core element of the old 
record API, which is deprecated.
    
    Using simple Java types makes the tests usually easier, more readable, and 
closer to the real behavior of the system (with respect to object reuse and 
mutability).
    
    Would be nice to move the tests from `Record` to `Tuple2<Long, String>` or 
something comparable.


> Implement Sort-Merge Outer Join algorithm
> -----------------------------------------
>
>                 Key: FLINK-2105
>                 URL: https://issues.apache.org/jira/browse/FLINK-2105
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Local Runtime
>            Reporter: Fabian Hueske
>            Assignee: Ricky Pogalz
>            Priority: Minor
>             Fix For: pre-apache
>
>
> Flink does not natively support outer joins at the moment. 
> This issue proposes to implement a sort-merge outer join algorithm that can 
> cover left, right, and full outer joins.
> The implementation can be based on the regular sort-merge join iterator 
> ({{ReusingMergeMatchIterator}} and {{NonReusingMergeMatchIterator}}, see also 
> {{MatchDriver}} class)
> The Reusing and NonReusing variants differ in whether object instances are 
> reused or new objects are created. I would start with the NonReusing variant 
> which is safer from a user's point of view and should also be easier to 
> implement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to