Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6203#discussion_r199427903
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractRestHandler.java
---
@@ -79,6 +79,7 @@ protected void respondToRequest(ChannelHandlerContext
ctx, HttpRequest httpReque
response = FutureUtils.completedExceptionally(e);
}
+ CompletableFuture<Void> processingFinishedFuture = new
CompletableFuture<>();
response.whenComplete((P resp, Throwable throwable) -> {
--- End diff --
seems odd to modify the signature to make the code prettier.
There's no use-case for the handlers to return anything but null, so why
even allow it? Doesn't this go against the principle of using the most
restrictive interface?
---
