[
https://issues.apache.org/jira/browse/FLINK-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531006#comment-16531006
]
ASF GitHub Bot commented on FLINK-9674:
---------------------------------------
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6216
Thanks @zentol, I have one remark (see above), besides that looks good to
me!
Additionally I had some ideas that came to mind that I think we could
discuss:
- We have a common pattern of `wait_for_sth` functions, that either
- get stuck in a loop for ever if the desired event doesn't happen (I
think `wait_for_job_state_transition` also behaves like that, right?)
- or iterate a fixed number of times and then continue execution, whereas
instead they should fail.
I think we should add an issue for that to refactor that over all the tests
to have consistent and useful behaviour
- Also I think that we could have the backup config and revert config as
part of the test runner and always do that, so we avoid running into a
corrupted flink-dist if tests don't behave correctly?
What do you think!
> Remove 65s sleep in QueryableState E2E test
> -------------------------------------------
>
> Key: FLINK-9674
> URL: https://issues.apache.org/jira/browse/FLINK-9674
> Project: Flink
> Issue Type: Improvement
> Components: Queryable State, Tests
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> The {{test_queryable_state_restart_tm.sh}} kills a taskmanager, waits for the
> loss to be noticed, starts a new tm and waits for the job to continue.
> {code}
> kill_random_taskmanager
> [...]
> sleep 65 # this is a little longer than the heartbeat timeout so that the TM
> is gone
> start_and_wait_for_tm
> {code}
> Instead of waiting for a fixed amount of time that is tied to some config
> value we should wait for a specific event, like the job being canceled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
