[
https://issues.apache.org/jira/browse/FLINK-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531030#comment-16531030
]
ASF GitHub Bot commented on FLINK-9674:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6216
@florianschmidt1994 I don't see the comment you're referring to :(
(Did you start a review, but wrote your comment separately? Then your
review would still be in progress!)
The issues you identified are certainly valid, but I'm wondering if it
really makes sense to invest time into this now.
There've been discussions about writing a python/java based framework for
the tests (and I've already started tinkering on a java version); so any
_significant_ changes we make to the bash-scripts might be subsumed soon™.
> Remove 65s sleep in QueryableState E2E test
> -------------------------------------------
>
> Key: FLINK-9674
> URL: https://issues.apache.org/jira/browse/FLINK-9674
> Project: Flink
> Issue Type: Improvement
> Components: Queryable State, Tests
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> The {{test_queryable_state_restart_tm.sh}} kills a taskmanager, waits for the
> loss to be noticed, starts a new tm and waits for the job to continue.
> {code}
> kill_random_taskmanager
> [...]
> sleep 65 # this is a little longer than the heartbeat timeout so that the TM
> is gone
> start_and_wait_for_tm
> {code}
> Instead of waiting for a fixed amount of time that is tied to some config
> value we should wait for a specific event, like the job being canceled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
