Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6201#discussion_r200522491
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
 ---
    @@ -160,10 +173,34 @@ abstract class BatchTableEnvironment(
           throw new TableException("Same number of field names and types 
required.")
         }
     
    -    tableSink match {
    +    val configuredSink = tableSink.configure(fieldNames, fieldTypes)
    +    registerTableSinkInternal(name, configuredSink)
    +  }
    +
    +  def registerTableSink(name: String, configuredSink: TableSink[_]): Unit 
= {
    --- End diff --
    
    could probably move this to based class `TableEnvironment` ?


---

Reply via email to