[
https://issues.apache.org/jira/browse/FLINK-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536823#comment-16536823
]
ASF GitHub Bot commented on FLINK-9511:
---------------------------------------
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6277#discussion_r200949235
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfiguration.java
---
@@ -61,7 +61,15 @@
private final TtlTimeCharacteristic timeCharacteristic;
private final Time ttl;
- public TtlConfig(
+ /**
+ * Creates a new state ttl configuration.
+ *
+ * @param ttlUpdateType The ttl update type configures when to update
last access timestamp which prolongs state TTL.
+ * @param stateVisibility The state visibility configures whether
expired user value can be returned or not.
+ * @param timeCharacteristic The time characteristic configures time
scale to use for ttl.
+ * @param ttl The ttl time.
+ */
+ protected StateTtlConfiguration(
--- End diff --
I think this can be private because config is not supposed to be extended
atm and to enforce builder usage.
The parameter comments can go then to the corresponding public builder
setter methods as they face the user API.
> Implement TTL config
> --------------------
>
> Key: FLINK-9511
> URL: https://issues.apache.org/jira/browse/FLINK-9511
> Project: Flink
> Issue Type: Sub-task
> Components: Java API, State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Andrey Zagrebin
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> `TtlConfig` has to be in flink core module.
> Another option is to consider adding TtlConfig builder.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
