[ 
https://issues.apache.org/jira/browse/FLINK-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536825#comment-16536825
 ] 

ASF GitHub Bot commented on FLINK-9511:
---------------------------------------

Github user azagrebin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6277#discussion_r200950760
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfiguration.java
 ---
    @@ -93,4 +101,59 @@ public Time getTtl() {
        public TtlTimeCharacteristic getTimeCharacteristic() {
                return timeCharacteristic;
        }
    +
    +   @Override
    +   public String toString() {
    +           return "StateTtlConfiguration{" +
    +                   "ttlUpdateType=" + ttlUpdateType +
    +                   ", stateVisibility=" + stateVisibility +
    +                   ", timeCharacteristic=" + timeCharacteristic +
    +                   ", ttl=" + ttl +
    +                   '}';
    +   }
    +
    +   public static Builder newBuilder() {
    --- End diff --
    
    I think when we create the new builder the configuration of at least TTL 
time should be enforced already here as a parameter because the default value 
for it is not obvious and user should be enforced to think about it.


> Implement TTL config
> --------------------
>
>                 Key: FLINK-9511
>                 URL: https://issues.apache.org/jira/browse/FLINK-9511
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Java API, State Backends, Checkpointing
>    Affects Versions: 1.6.0
>            Reporter: Andrey Zagrebin
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> `TtlConfig` has to be in flink core module.
> Another option is to consider adding TtlConfig builder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to