[
https://issues.apache.org/jira/browse/FLINK-9784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538773#comment-16538773
]
ASF GitHub Bot commented on FLINK-9784:
---------------------------------------
GitHub user nekrassov opened a pull request:
https://github.com/apache/flink/pull/6298
[FLINK-9784] Fix inconsistent use of 'static' in AsyncIOExample.java
## What is the purpose of the change
This patch fixes inconsistent use of `static` in AsyncIOExample.java that
can lead to incorrect code execution.
## Brief change log
Changed `executorService` and `random` from static to instance-specific,
removed no longer needed `counter`, and removed synchronization on class that's
no longer needed either.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nekrassov/flink FLINK-9784
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6298
----
commit 3b316e3046c3f6377b92541b30d70748afa4e0bc
Author: an4828 <nekrassov@...>
Date: 2018-07-10T14:59:35Z
[FLINK-9784] Fix inconsistent use of 'static' in AsyncIOExample.java
----
> Inconsistent use of 'static' in AsyncIOExample.java
> ---------------------------------------------------
>
> Key: FLINK-9784
> URL: https://issues.apache.org/jira/browse/FLINK-9784
> Project: Flink
> Issue Type: Bug
> Components: Examples
> Affects Versions: 1.5.0, 1.4.2
> Reporter: Alexei Nekrassov
> Assignee: Alexei Nekrassov
> Priority: Minor
> Labels: pull-request-available
>
> In SampleAsyncFunction having _executorService_ and _random_ as static, but
> _counter_ as instance-specific will not work when someone creates a second
> instance of SampleAsyncFunction. In second SampleAsyncFunction the _counter_
> will be 0 and we will re-intialize static _executorService_ and _random_,
> thus interfering with the first SampleAsyncFunction object.
> To fix this example and make it clearer, make _executorService_ and _random_
> instance-specific. That will make _counter_ redundant; also synchronization
> on class will no longer be needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
