[
https://issues.apache.org/jira/browse/FLINK-9801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539860#comment-16539860
]
ASF GitHub Bot commented on FLINK-9801:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6304
[FLINK-9801][build] Add missing example dependencies to flink-dist
## What is the purpose of the change
With this PR `flink-dist` explicitly depends on `flink-examples-batch` and
`flink-examples-streaming`, to ensure that both modules are built
a) before flink-dist
b) when compiling flink-dist with the `-am` flag.
## Brief change log
* add dependencies to both modules
* add exclusions to shade-plugin so they aren't included in the
`flink-dist` jar
## Verifying this change
Manually verified.
a) run `mvn validate -pl flink-dist -am` and check that both example
modules are in the reactor build before flink-dist
b) compile flink-dist and check that code from neither module is present in
flink-dist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9801
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6304
----
commit d330a2587035491b98460e7686bdb0b036182de4
Author: zentol <chesnay@...>
Date: 2018-07-11T10:23:24Z
[FLINK-9801][build] Add missing example dependencies to flink-dist
----
> flink-dist is missing dependency on flink-examples
> --------------------------------------------------
>
> Key: FLINK-9801
> URL: https://issues.apache.org/jira/browse/FLINK-9801
> Project: Flink
> Issue Type: Improvement
> Components: Build System, Examples
> Affects Versions: 1.5.1, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.1, 1.6.0
>
>
> For the assembly of {{flink-dist}} we copy various batch/streaming examples
> directly from the respective /target directory.
> Never mind that this is already a problem as is (see FLINK-9582),
> {{flink-dist}} defines no dependency on these modules.
> If you were to only compile {{flink-dist}} with the {{-am}} flag (to also
> build all dependencies) it thus _may_ or _may not_ happen that these modules
> are actually compiled, which could cause these examples to not be included in
> the final assembly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
