[ 
https://issues.apache.org/jira/browse/FLINK-9801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539899#comment-16539899
 ] 

ASF GitHub Bot commented on FLINK-9801:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/6304
  
    LGTM


> flink-dist is missing dependency on flink-examples
> --------------------------------------------------
>
>                 Key: FLINK-9801
>                 URL: https://issues.apache.org/jira/browse/FLINK-9801
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System, Examples
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2, 1.6.0
>
>
> For the assembly of {{flink-dist}} we copy various batch/streaming examples 
> directly from the respective /target directory.
> Never mind that this is already a problem as is (see FLINK-9582), 
> {{flink-dist}} defines no dependency on these modules.
> If you were to only compile {{flink-dist}} with the {{-am}} flag (to also 
> build all dependencies) it thus _may_ or _may not_ happen that these modules 
> are actually compiled, which could cause these examples to not be included in 
> the final assembly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to