[
https://issues.apache.org/jira/browse/FLINK-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540300#comment-16540300
]
ASF GitHub Bot commented on FLINK-9755:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6272#discussion_r201744623
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferListener.java
---
@@ -27,6 +27,13 @@
/**
* Notification callback if a buffer is recycled and becomes available
in buffer pool.
*
+ * <p>Note: responsibility on recycling the given buffer is transferred
to this implementation,
+ * including any errors that lead to exceptions being thrown!
+ *
+ * <p><strong>BEWARE:</strong> since this may be called from outside
the thread that relies on
+ * the listener's logic, any exception that occurs with this handler
should be forwarded to the
+ * responsible thread for handling (the buffer pool ignores any {@link
Throwable} from here!).
--- End diff --
However now `LocalBufferPool` is not ignoring exceptions, but it is
forwarding them
> Exceptions in RemoteInputChannel#notifyBufferAvailable() are not propagated
> to the responsible thread
> -----------------------------------------------------------------------------------------------------
>
> Key: FLINK-9755
> URL: https://issues.apache.org/jira/browse/FLINK-9755
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.5.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.5.2, 1.6.0
>
>
> The credit-based flow control implementation of
> RemoteInputChannel#notifyBufferAvailable() does not forward errors (like the
> {{IllegalStateException}}) to the thread that is being notified. The calling
> code at {{LocalBufferPool#recycle}}, however, relies on the callback
> forwarding errors and completely ignores any failures.
> Therefore, we could end up with a program waiting forever for the callback
> and not even a failure message in the logs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
