Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6272#discussion_r201744623
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferListener.java
---
@@ -27,6 +27,13 @@
/**
* Notification callback if a buffer is recycled and becomes available
in buffer pool.
*
+ * <p>Note: responsibility on recycling the given buffer is transferred
to this implementation,
+ * including any errors that lead to exceptions being thrown!
+ *
+ * <p><strong>BEWARE:</strong> since this may be called from outside
the thread that relies on
+ * the listener's logic, any exception that occurs with this handler
should be forwarded to the
+ * responsible thread for handling (the buffer pool ignores any {@link
Throwable} from here!).
--- End diff --
However now `LocalBufferPool` is not ignoring exceptions, but it is
forwarding them
---
